[compiler-rt] XFAIL: lld-available lit.cfg tag does not work as intended. (PR #99056)
Kamau Bridgeman via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 16 09:15:38 PDT 2024
https://github.com/kamaub updated https://github.com/llvm/llvm-project/pull/99056
>From 5691ebfd6286790b293d672b51633f4bb4f8bf24 Mon Sep 17 00:00:00 2001
From: Kamau Bridgeman <kamau.bridgeman at ibm.com>
Date: Tue, 16 Jul 2024 12:00:25 -0400
Subject: [PATCH 1/2] XFAIL: lld-available lit.cfg tag does not work as
intended.
This change XFAILs instrprof-gc-sections.c compiler-rt test case
because it uses the `lld-available` lit.config tag which erroneously
uses the CMAKE_LINKER if it is lld instead of checking for the
latest and greatest lld available. A patch is in the works to fix
this.
This change is to bring the clang-ppc64le-linux-test-suite and
clang-ppc64le-linux-multistage back to green as they were broken
as of PR #98382
---
compiler-rt/test/profile/instrprof-gc-sections.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compiler-rt/test/profile/instrprof-gc-sections.c b/compiler-rt/test/profile/instrprof-gc-sections.c
index 8b84c0a242180..06d3eac355638 100644
--- a/compiler-rt/test/profile/instrprof-gc-sections.c
+++ b/compiler-rt/test/profile/instrprof-gc-sections.c
@@ -1,7 +1,7 @@
// REQUIRES: linux, lld-available
// FIXME: Investigate and fix.
-// XFAIL: powerpc64-target-arch
+// XFAIL: powerpc64-target-arch,powerpc64le-target-arch
// RUN: rm -rf %t.profraw
// RUN: %clang_profgen=%t.profraw -fuse-ld=lld -fcoverage-mapping -mllvm -enable-name-compression=false -DCODE=1 -ffunction-sections -fdata-sections -Wl,--gc-sections -o %t %s
>From 7798c3b00a957396fa24ae71e9b23048792a0800 Mon Sep 17 00:00:00 2001
From: Kamau Bridgeman <kamau.a.bridgeman at gmail.com>
Date: Tue, 16 Jul 2024 12:15:30 -0400
Subject: [PATCH 2/2] Apply suggestions from code review
---
compiler-rt/test/profile/instrprof-gc-sections.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compiler-rt/test/profile/instrprof-gc-sections.c b/compiler-rt/test/profile/instrprof-gc-sections.c
index 06d3eac355638..88510205bcc45 100644
--- a/compiler-rt/test/profile/instrprof-gc-sections.c
+++ b/compiler-rt/test/profile/instrprof-gc-sections.c
@@ -1,7 +1,7 @@
// REQUIRES: linux, lld-available
// FIXME: Investigate and fix.
-// XFAIL: powerpc64-target-arch,powerpc64le-target-arch
+// XFAIL: powerpc64-target-arch, powerpc64le-target-arch
// RUN: rm -rf %t.profraw
// RUN: %clang_profgen=%t.profraw -fuse-ld=lld -fcoverage-mapping -mllvm -enable-name-compression=false -DCODE=1 -ffunction-sections -fdata-sections -Wl,--gc-sections -o %t %s
More information about the llvm-commits
mailing list