[llvm] [Support] Don't use StringRef::equals in Path.inc (PR #98839)

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 16 04:34:14 PDT 2024


rorth wrote:

Thanks for the clarification.  In the old days, before LLVM switched to pull requests, I'd just have committed the patch, especially in a case like this with an obvious patch to unbreak the build.  However, I wasn't sure if this was appropriate in the new world, so meant to err on the side of caution while still restoring the build quickly.

Besides, I meant to alert Kazu, wondering if he'd missed the buildbot failure notification in [[ADT] Remove StringRef::equals](https://github.com/llvm/llvm-project/pull/98735) which wouldn't work with a simple commit.

Another advantage of the pull request route is that you get a verification of the description's markup.

> If you only wanted to create the pull request to run automated presubmit checks, please create the PR with the skip-precommit-approval to indicate that)

That would be `git commit --no-verify`?



https://github.com/llvm/llvm-project/pull/98839


More information about the llvm-commits mailing list