[llvm] Split DWARFFormValue::getReference into four functions (PR #98905)

Tue Jul 16 04:07:13 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-nfc` running on `bolt-worker` while building `llvm` at step 7 "build-bolt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/92/builds/1768

Here is the relevant piece of the build log for the reference:
```
Step 7 (build-bolt) failure: build (failure)
...
14.724 [75/18/50] Linking CXX static library lib/libLLVMProfileData.a
14.868 [74/18/51] Linking CXX static library lib/libLLVMDWARFLinker.a
14.996 [73/18/52] Linking CXX static library lib/libLLVMDWARFLinkerClassic.a
15.320 [72/18/53] Linking CXX static library lib/libLLVMVectorize.a
15.734 [71/18/54] Linking CXX static library lib/libLLVMAArch64CodeGen.a
16.658 [70/18/55] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/BinarySection.cpp.o
16.700 [69/18/56] Building CXX object tools/bolt/lib/Passes/CMakeFiles/LLVMBOLTPasses.dir/AsmDump.cpp.o
17.299 [68/18/57] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/BinaryFunctionCallGraph.cpp.o
17.824 [67/18/58] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/BinaryFunctionProfile.cpp.o
18.021 [66/18/59] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/DIEBuilder.cpp.o
FAILED: tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/DIEBuilder.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/lib/Core -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/bolt/lib/Core -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/llvm/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/bolt/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/bolt/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/DIEBuilder.cpp.o -MF tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/DIEBuilder.cpp.o.d -o tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/DIEBuilder.cpp.o -c /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/bolt/lib/Core/DIEBuilder.cpp
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/bolt/lib/Core/DIEBuilder.cpp: In member function ‘llvm::DWARFDie llvm::bolt::DIEBuilder::resolveDIEReference(const llvm::DWARFFormValue&, llvm::DWARFAbbreviationDeclaration::AttributeSpec, llvm::DWARFUnit*&, llvm::DWARFDebugInfoEntry&)’:
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/bolt/lib/Core/DIEBuilder.cpp:559:34: error: ‘const class llvm::DWARFFormValue’ has no member named ‘getAsReference’; did you mean ‘getAsReferenceUVal’?
  559 |   uint64_t RefOffset = *RefValue.getAsReference();
      |                                  ^~~~~~~~~~~~~~
      |                                  getAsReferenceUVal
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/bolt/lib/Core/DIEBuilder.cpp: In member function ‘void llvm::bolt::DIEBuilder::cloneDieReferenceAttribute(llvm::DIE&, const llvm::DWARFUnit&, const llvm::DWARFDie&, llvm::DWARFAbbreviationDeclaration::AttributeSpec, const llvm::DWARFFormValue&)’:
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/bolt/lib/Core/DIEBuilder.cpp:610:29: error: ‘const class llvm::DWARFFormValue’ has no member named ‘getAsReference’; did you mean ‘getAsReferenceUVal’?
  610 |   const uint64_t Ref = *Val.getAsReference();
      |                             ^~~~~~~~~~~~~~
      |                             getAsReferenceUVal
18.506 [66/17/60] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/DebugData.cpp.o
19.003 [66/16/61] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/GDBIndex.cpp.o
19.270 [66/15/62] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/BinaryEmitter.cpp.o
20.126 [66/14/63] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/DebugNames.cpp.o
20.260 [66/13/64] Building CXX object tools/bolt/lib/Rewrite/CMakeFiles/LLVMBOLTRewrite.dir/DWARFRewriter.cpp.o
20.549 [66/12/65] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/JumpTable.cpp.o
20.735 [66/11/66] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/DynoStats.cpp.o
21.149 [66/10/67] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/BinaryContext.cpp.o
21.491 [66/9/68] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/ParallelUtilities.cpp.o
21.583 [66/8/69] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/HashUtilities.cpp.o
22.016 [66/7/70] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/Exceptions.cpp.o
22.312 [66/6/71] Building CXX object tools/bolt/lib/Passes/CMakeFiles/LLVMBOLTPasses.dir/Aligner.cpp.o
23.116 [66/5/72] Building CXX object tools/bolt/lib/Passes/CMakeFiles/LLVMBOLTPasses.dir/CacheMetrics.cpp.o
23.432 [66/4/73] Building CXX object tools/bolt/lib/Passes/CMakeFiles/LLVMBOLTPasses.dir/CMOVConversion.cpp.o
23.500 [66/3/74] Building CXX object tools/bolt/lib/Passes/CMakeFiles/LLVMBOLTPasses.dir/DataflowAnalysis.cpp.o
25.243 [66/2/75] Building CXX object tools/bolt/lib/Core/CMakeFiles/LLVMBOLTCore.dir/BinaryFunction.cpp.o
26.682 [66/1/76] Building CXX object tools/bolt/lib/Passes/CMakeFiles/LLVMBOLTPasses.dir/BinaryPasses.cpp.o
ninja: build stopped: subcommand failed.

```

https://github.com/llvm/llvm-project/pull/98905