[llvm] [LV] Check isPredInst instead of isScalarWithPred in uniform analysis. (PR #98892)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 15 15:38:45 PDT 2024
================
@@ -3907,7 +3907,7 @@ void LoopVectorizationCostModel::collectLoopUniforms(ElementCount VF) {
SetVector<Instruction *> Worklist;
// Add uniform instructions demanding lane 0 to the worklist. Instructions
- // that are scalar with predication must not be considered uniform after
+ // that are require predication must not be considered uniform after
// vectorization, because that would create an erroneous replicating region
// where only a single instance out of VF should be formed.
// TODO: optimize such seldom cases if found important, see PR40816.
----------------
ayalz wrote:
Do the github issues offer additional seldom cases of lost uniformity potentially worth optimizing if important, to be added to TODO?
https://github.com/llvm/llvm-project/pull/98892
More information about the llvm-commits
mailing list