[compiler-rt] [nsan] Use ALIGNED instead of alignas (NFC) (PR #98933)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 15 11:29:42 PDT 2024
nikic wrote:
> We already require support for `alignas` in some compiler-rt library files: `rg -w alignas compiler-rt/lib` (lsan, scudo, gwp_asan, xray, etc).
The problem here is not alignas in general, but a very specific pattern that only occurs inside nsan. You want to look for `git grep -B2 alignas compiler-rt | grep SANITIZER_INTERFACE_ATTRIBUTE`.
> Old compilers can use `LLVM_ENABLE_RUNTIMES=compiler-rt`, which will use just built Clang to build the runtime libraries.
As far as I know, compiler-rt is subject to the LLVM monorepo host compiler requirements (https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library). Only the libcxx and libcxxabi projects are exempt from these.
compiler-rt is commonly used by compilers other than clang, and the host compiler used to build it has no relation to the toolchain it will be part of. For such uses, only LLVM and compiler-rt will be built, but clang will generally not be built.
In any case, changing the host compiler requirements for compiler-rt would require an RFC.
https://github.com/llvm/llvm-project/pull/98933
More information about the llvm-commits
mailing list