[llvm] [SandboxIR] Add more Instruction member functions (PR #98588)

[Arthur Eubanks via llvm-commits]

================
@@ -463,18 +463,10 @@ std::unique_ptr<Value> Context::detachLLVMValue(llvm::Value *V) {
 }
 
 std::unique_ptr<Value> Context::detach(Value *V) {
-#ifndef NDEBUG
-  switch (V->getSubclassID()) {
-  case Value::ClassID::Constant:
-    llvm_unreachable("Can't detach a constant!");
-    break;
-  case Value::ClassID::User:
-    llvm_unreachable("Can't detach a user!");
-    break;
-  default:
-    break;
-  }
-#endif
+  assert(V->getSubclassID() != Value::ClassID::Constant &&
+         "Can't detach a constant!");
+  assert(V->getSubclassID() != Value::ClassID::User &&
+         "Can't detach a constant!");
----------------
aeubanks wrote:

s/constant/user

https://github.com/llvm/llvm-project/pull/98588