[llvm] ADT/Matrix: two-dimensional Container with View (PR #98893)

[David Blaikie via llvm-commits]

dwblaikie wrote:




> > > Yes, and that's what I've implemented in MatrixView. The storage class is essentially SmallVector with an additional field for tracking the number of columns. I need to track the number of columns, so that I can reconstruct the View after the underlying storage has been reallocated.
> > 
> > 
> > Thanks you for the explanation. If this is the case, I don't think the name `Matrix*` is the most fitting. I'd call it something like 'JaggedArray': https://en.wikipedia.org/wiki/Jagged_array.
> 
> I suppose it is a MatrixStorage with a JaggedArrayView. Thanks for the name suggestion: I wasn't aware of this terminology. I would, however, like some suggestions for names from other reviewers as well, before we finalize on something.

Why does the view support jagged arrays, though? Is that needed?

https://github.com/llvm/llvm-project/pull/98893