[clang] [lld] [llvm] Conditionalize use of POSIX features missing on WASI/WebAssembly (PR #92677)
James Y Knight via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 14 17:37:32 PDT 2024
================
@@ -41,6 +41,8 @@
using namespace llvm;
+#if defined(_WIN32) || !defined(__wasi__)
----------------
jyknight wrote:
This conditional is weird; there's no case where `__wasi__` is defined at the same time as `_WIN32`, so you just mean `#if !defined(__wasi__)`.
Also you've removed the entire type's implementation, but not the declaration in the header, which is broken.
https://github.com/llvm/llvm-project/pull/92677
More information about the llvm-commits
mailing list