[llvm] [Support] Don't use StringRef::equals in Path.inc (PR #98839)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 14 14:49:44 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-support
Author: Rainer Orth (rorth)
<details>
<summary>Changes</summary>
The removal of StringRef::equals in
3fa409f2318ef790cc44836afe9a72830715ad84 broke the [Solaris/sparcv9](https://lab.llvm.org/buildbot/#/builders/13/builds/724) and [Solaris/amd64](https://lab.llvm.org/staging/#/builders/94/builds/5176) buildbots:
```
In file included from /vol/llvm/src/llvm-project/git/llvm/lib/Support/Path.cpp:1200:
/vol/llvm/src/llvm-project/git/llvm/lib/Support/Unix/Path.inc:519:18: error: no member named 'equals' in 'llvm::StringRef'
519 | return !fstype.equals("nfs");
| ~~~~~~ ^
```
Fixed by switching to `operator!=` instead.
Tested on sparcv9-sun-solaris2.11 and amd64-pc-solaris2.11.
---
Full diff: https://github.com/llvm/llvm-project/pull/98839.diff
1 Files Affected:
- (modified) llvm/lib/Support/Unix/Path.inc (+1-1)
``````````diff
diff --git a/llvm/lib/Support/Unix/Path.inc b/llvm/lib/Support/Unix/Path.inc
index 6e679f74869f0..cf05db546e021 100644
--- a/llvm/lib/Support/Unix/Path.inc
+++ b/llvm/lib/Support/Unix/Path.inc
@@ -516,7 +516,7 @@ static bool is_local_impl(struct STATVFS &Vfs) {
// target
StringRef fstype(Vfs.f_basetype);
// NFS is the only non-local fstype??
- return !fstype.equals("nfs");
+ return fstype != "nfs";
#elif defined(_AIX)
// Call mntctl; try more than twice in case of timing issues with a concurrent
// mount.
``````````
</details>
https://github.com/llvm/llvm-project/pull/98839
More information about the llvm-commits
mailing list