[lld] [llvm] [llvm-dlltool] Fix renamed imports without a separate regular import entry (PR #98229)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 14 02:06:33 PDT 2024
Martin =?utf-8?q?Storsjö?= <martin at martin.st>,
Martin =?utf-8?q?Storsjö?= <martin at martin.st>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/98229 at github.com>
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff d5285fef00f6c5a725a515118192dd117fc3c665 e37376c4e8e2c77a2b98449a5b1aadfa5b6d675b --extensions cpp -- llvm/lib/Object/COFFImportFile.cpp llvm/lib/Object/COFFModuleDefinition.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Object/COFFImportFile.cpp b/llvm/lib/Object/COFFImportFile.cpp
index a44ff2d5a7..2458a53cb6 100644
--- a/llvm/lib/Object/COFFImportFile.cpp
+++ b/llvm/lib/Object/COFFImportFile.cpp
@@ -772,9 +772,9 @@ Error writeImportLibrary(StringRef ImportName, StringRef Path,
Members.push_back(OF.createWeakExternal(Symbol, D.Name, false, M));
Members.push_back(OF.createWeakExternal(Symbol, D.Name, true, M));
} else {
- Members.push_back(OF.createShortImport(
- D.Name, D.Export->Ordinal, D.ImpType, IMPORT_NAME_EXPORTAS,
- D.Export->ImportName, M));
+ Members.push_back(OF.createShortImport(D.Name, D.Export->Ordinal,
+ D.ImpType, IMPORT_NAME_EXPORTAS,
+ D.Export->ImportName, M));
}
}
return Error::success();
``````````
</details>
https://github.com/llvm/llvm-project/pull/98229
More information about the llvm-commits
mailing list