[llvm] [LV]Set tailfolding styles before computing feasible max VF. (PR #91403)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Jul 13 15:02:57 PDT 2024
https://github.com/ayalz commented:
This patch seems to involve two parts which best be committed separately, unless there's a reason not to?
1. introducing isScalableVectorizationAllowed() to refactor getMaxLegalScalableVF() which spends most of its time checking if isScalableVectorizationAllowed() and only if so to compute and return the desired VF(). This seems to be consistent with having getMax*VF() also take care of isThereAnyAllowed*VF(), sigh.
2. set tail folding style before being sure there is tail to fold, and unset it later when sure there isn't. This part lacks an explanation why this is needed, in a comment and in a test, in addition to the commit message.
The first part should be a simple standalone NFC. Regarding the second part, note VPlan's roadmap direction to first strip-mine the loop considering its tail folded, and later consider if to unfold the tail - potentially leading to epilog vectorization, etc.
https://github.com/llvm/llvm-project/pull/91403
More information about the llvm-commits
mailing list