[llvm] [DXIL] Add constraint specification and backend implementation of DXIL Ops (PR #97593)
Damyan Pepper via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 12 14:13:37 PDT 2024
================
@@ -124,32 +117,29 @@ DXILOperationDesc::DXILOperationDesc(const Record *R) {
// the comment before the definition of class LLVMMatchType in
// llvm/IR/Intrinsics.td
SmallVector<int> OverloadParamIndices;
- for (unsigned i = 0; i < TypeRecsSize; i++) {
- auto TR = TypeRecs[i];
+ for (unsigned I = 0; I < ParamTypeRecsSize; I++) {
+ auto TR = ParamTypeRecs[I];
// Track operation parameter indices of any overload types
- auto isAny = TR->getValueAsInt("isAny");
- if (isAny == 1) {
+ auto IsAny = TR->getValueAsInt("isAny");
+ if (IsAny == 1) {
// TODO: At present it is expected that all overload types in a DXIL Op
// are of the same type. Hence, OverloadParamIndices will have only one
// element. This implies we do not need a vector. However, until more
// (all?) DXIL Ops are added in DXIL.td, a vector is being used to flag
// cases this assumption would not hold.
----------------
damyanp wrote:
Is this comment out of date now?
https://github.com/llvm/llvm-project/pull/97593
More information about the llvm-commits
mailing list