[llvm] AMDGPU: Assume true in getVOPNIsSingle helpers (PR #98516)
Joe Nash via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 12 06:50:51 PDT 2024
Sisyph wrote:
> > I don't think we should be relying on the default behavior. So wouldn't it make sense to mark your instructions of interest as isCodeGenOnly = 0, if they are actually getting printed?
>
> They are all printed and real instructions, except for the purposes of disassembly. They have ambiguous decodings we need to deal with, so the encoded aliases need to be isCodeGenOnly
This seems like a contradiction to me, and is asking for a different kind of fix. But if you want to fix it this way, can you add a test, so someone else doesn't come along and try to switch it back later?
https://github.com/llvm/llvm-project/pull/98516
More information about the llvm-commits
mailing list