[compiler-rt] [sanitizer] Add missing newlines to __sanitizer_set_report_path() error messages (PR #98626)

Ilya Leoshkevich via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 12 05:29:20 PDT 2024


https://github.com/iii-i created https://github.com/llvm/llvm-project/pull/98626

"Can't open file:" and "Can't create directory:" are lacking a newline.

>From 273fd8ed9df9e1741a60111f9bd56eac849662e3 Mon Sep 17 00:00:00 2001
From: Ilya Leoshkevich <iii at linux.ibm.com>
Date: Fri, 12 Jul 2024 14:02:57 +0200
Subject: [PATCH] [sanitizer] Add missing newlines to
 __sanitizer_set_report_path() error messages

"Can't open file:" and "Can't create directory:" are lacking a newline.
---
 compiler-rt/lib/sanitizer_common/sanitizer_file.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp
index 7ef499ce07b13..96af270f9d8b5 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_file.cpp
@@ -69,7 +69,7 @@ void ReportFile::ReopenIfNecessary() {
     WriteToFile(kStderrFd, ErrorMsgPrefix, internal_strlen(ErrorMsgPrefix));
     WriteToFile(kStderrFd, full_path, internal_strlen(full_path));
     char errmsg[100];
-    internal_snprintf(errmsg, sizeof(errmsg), " (reason: %d)", err);
+    internal_snprintf(errmsg, sizeof(errmsg), " (reason: %d)\n", err);
     WriteToFile(kStderrFd, errmsg, internal_strlen(errmsg));
     Die();
   }
@@ -88,6 +88,8 @@ static void RecursiveCreateParentDirs(char *path) {
       const char *ErrorMsgPrefix = "ERROR: Can't create directory: ";
       WriteToFile(kStderrFd, ErrorMsgPrefix, internal_strlen(ErrorMsgPrefix));
       WriteToFile(kStderrFd, path, internal_strlen(path));
+      const char *ErrorMsgSuffix = "\n";
+      WriteToFile(kStderrFd, ErrorMsgSuffix, internal_strlen(ErrorMsgSuffix));
       Die();
     }
     path[i] = save;



More information about the llvm-commits mailing list