[llvm] [SPIRV] Emitting DebugSource, DebugCompileUnit (PR #97558)

[Vyacheslav Levytskyy via llvm-commits]

VyacheslavLevytskyy wrote:

@bwlodarcz Please feel free to ignore my advise to consider re-using parts of the Translator's test suite.

However, quality and coverage of test cases must be adequate, and your single test case doesn't demonstrate correctness of the PR. Namely, it does not check possible options (e.g., module has no functions but has debug info, module has incorrect debug info, ...), and within the single option that you check the test case doesn't have enough CHECK's.

To explain my point of view, consider the recent fail of github actions step "Test SPIR-V / Lit Tests" applied to this PR. The error with OpLabel generation was caught by spirv-val rather than your CHECK's. The test didn't have CHECK's relevant to this error before spirv-val discovered it, and it didn't get any new CHECK's even after your recent commit https://github.com/llvm/llvm-project/pull/97558/commits/ad701a28544bf83550dde24e2e667443d0865db5 that fixed spirv-val's complaint.

Please consider extending test cases as a part of this PR. Thank you.

https://github.com/llvm/llvm-project/pull/97558