[llvm] [SLP]Correctly detect minnum/maxnum patterns for select/cmp operations on floats. (PR #98570)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 11 17:51:50 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff e57d7dae6f28af513a17a5d6813399f04245e9e1 b25ea95f04cc51ce4ee3f90f239896f1e918514b --extensions cpp -- llvm/lib/Analysis/ValueTracking.cpp llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index b2b56a6635..9798f6ba92 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -9636,9 +9636,9 @@ BoUpSLP::getEntryCost(const TreeEntry *E, ArrayRef<Value *> VectorizedVals,
? CmpInst::BAD_FCMP_PREDICATE
: CmpInst::BAD_ICMP_PREDICATE;
- InstructionCost ScalarCost = TTI->getCmpSelInstrCost(E->getOpcode(), OrigScalarTy,
- Builder.getInt1Ty(), CurrentPred, CostKind,
- VI);
+ InstructionCost ScalarCost = TTI->getCmpSelInstrCost(
+ E->getOpcode(), OrigScalarTy, Builder.getInt1Ty(), CurrentPred,
+ CostKind, VI);
auto IntrinsicAndUse = canConvertToMinOrMaxIntrinsic(VI);
if (IntrinsicAndUse.first != Intrinsic::not_intrinsic) {
IntrinsicCostAttributes CostAttrs(IntrinsicAndUse.first, OrigScalarTy,
@@ -9649,9 +9649,9 @@ BoUpSLP::getEntryCost(const TreeEntry *E, ArrayRef<Value *> VectorizedVals,
// dead and we can adjust the cost by removing their cost.
if (IntrinsicAndUse.second) {
auto *CI = cast<CmpInst>(VI->getOperand(0));
- IntrinsicCost -= TTI->getCmpSelInstrCost(CI->getOpcode(), OrigScalarTy,
- Builder.getInt1Ty(),
- CI->getPredicate(), CostKind, CI);
+ IntrinsicCost -= TTI->getCmpSelInstrCost(
+ CI->getOpcode(), OrigScalarTy, Builder.getInt1Ty(),
+ CI->getPredicate(), CostKind, CI);
}
ScalarCost = std::min(ScalarCost, IntrinsicCost);
}
@@ -9675,7 +9675,8 @@ BoUpSLP::getEntryCost(const TreeEntry *E, ArrayRef<Value *> VectorizedVals,
// If the selects are the only uses of the compares, they will be
// dead and we can adjust the cost by removing their cost.
if (IntrinsicAndUse.second) {
- auto *CI = cast<CmpInst>(cast<Instruction>(VL.front())->getOperand(0));
+ auto *CI =
+ cast<CmpInst>(cast<Instruction>(VL.front())->getOperand(0));
IntrinsicCost -= TTI->getCmpSelInstrCost(CI->getOpcode(), VecTy,
MaskTy, VecPred, CostKind);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/98570
More information about the llvm-commits
mailing list