[lld] [lld][AArch64] Fix handling of SHT_REL relocation addends. (PR #98291)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 14:19:31 PDT 2024


================
@@ -366,11 +421,13 @@ static void write32AArch64Addr(uint8_t *l, uint64_t imm) {
   write32le(l, (read32le(l) & ~mask) | immLo | immHi);
 }
 
-static void or32le(uint8_t *p, int32_t v) { write32le(p, read32le(p) | v); }
+static void writeBits32le(uint8_t *p, int32_t v, uint32_t mask) {
----------------
smithp35 wrote:

Perhaps `writeMaskedBitsle`?

Just a suggestion, not got a strong opinion, could make the third parameter more obvious at the callsite.

https://github.com/llvm/llvm-project/pull/98291


More information about the llvm-commits mailing list