[llvm] [llvm-dlltool] Remove the i386 underscore prefix from COFFImportFile::ImportName. NFC. (PR #98226)

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 14:19:21 PDT 2024


================
@@ -691,10 +692,15 @@ Error writeImportLibrary(StringRef ImportName, StringRef Path,
       }
 
       if (!E.ImportName.empty() && Name != E.ImportName) {
+        StringRef Prefix = "";
+        if (Machine == IMAGE_FILE_MACHINE_I386 && AddUnderscores)
+          Prefix = "_";
----------------
mstorsjo wrote:

FWIW, I traced the addition of the `isDecorated` call to 284ab80f8d055, and it doesn't necessarily seem motivated there. On current git main, we can also remove the call entirely, without affecting any testcase in either `check-llvm` or `check-lld`.

So it seems like the whole call may have been misguided to begin with.

https://github.com/llvm/llvm-project/pull/98226


More information about the llvm-commits mailing list