[llvm] [InstCombine][AMDGPU] Disable PtrReplacer when select has mismatch AS. (PR #98456)

Shilei Tian via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 10:33:37 PDT 2024


================
@@ -270,16 +270,54 @@ class PointerReplacer {
     unsigned ToAS = ASC->getDestAddressSpace();
     return (FromAS == ToAS) || IC.isValidAddrSpaceCast(FromAS, ToAS);
   }
+  bool FoundASC(const Value *TrueOp) const;
----------------
shiltian wrote:

```suggestion
  bool hasFoundASC(const Value *TrueOp) const;
```

Based on the LLVM code standard, function name starts with a verb and non-capitalized letter.

https://github.com/llvm/llvm-project/pull/98456


More information about the llvm-commits mailing list