[llvm] [llvm-objcopy] Add possibility to verify .note section format (PR #90458)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 03:25:30 PDT 2024


https://github.com/jh7370 approved this pull request.

LGTM, but could you make some changes to the PR title and description as follows, please, before merging?

1) Change the title to "[llvm-objcopy] Add verification of added .note section format". This makes it clearer that the new behaviour is on by default.
2) Add a description outlining the new behaviour, in particular the new option, in more detail. Something like:

> This commit adds a --verify-note-sections option to llvm-objcopy, which enables checking that added .note sections conform to the SHT_NOTE section format. This option is enabled by default, but can be disabled with --no-verify-note-sections.

https://github.com/llvm/llvm-project/pull/90458


More information about the llvm-commits mailing list