[llvm] [AMDGPU] Do not use original PHIs in coercion chains (PR #98063)

[Matt Arsenault via llvm-commits]

================
@@ -365,13 +365,26 @@ bool LiveRegOptimizer::optimizeLiveType(
       else
         MissingIncVal = true;
     }
-    Instruction *DeadInst = Phi;
+
     if (MissingIncVal) {
-      DeadInst = cast<Instruction>(ValMap[Phi]);
-      // Do not use the dead phi
-      ValMap[Phi] = Phi;
-    }
-    DeadInsts.emplace_back(DeadInst);
+      Value *DeadVal = ValMap[Phi];
+      // The coercion chain of the PHI is broken. Delete the Phi
+      // from the ValMap and any connected / user Phis.
----------------
arsenm wrote:

Isn't that what the WeakTrackingVH is for? 

https://github.com/llvm/llvm-project/pull/98063