[llvm] [llvm-dlltool] Remove the i386 underscore prefix from COFFImportFile::ImportName. NFC. (PR #98226)

[Jacek Caban via llvm-commits]

Martin =?utf-8?q?Storsjö?= <martin at martin.st>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/98226 at github.com>


================
@@ -691,10 +692,15 @@ Error writeImportLibrary(StringRef ImportName, StringRef Path,
       }
 
       if (!E.ImportName.empty() && Name != E.ImportName) {
+        StringRef Prefix = "";
+        if (Machine == IMAGE_FILE_MACHINE_I386 && AddUnderscores)
+          Prefix = "_";
----------------
cjacek wrote:

I think this is not exactly the same as the code removed from `COFFModuleDefinition`. The original code also checks if the symbol is not decorated before adding the prefix.

https://github.com/llvm/llvm-project/pull/98226