[clang] [llvm] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 05:58:48 PDT 2024


================
@@ -32,7 +32,9 @@
 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/StringSet.h"
 #include "llvm/Frontend/OpenMP/OMPGridValues.h"
+#include "llvm/IR/Attributes.h"
 #include "llvm/IR/DerivedTypes.h"
+#include "llvm/IR/Function.h"
----------------
nikic wrote:

Could you please move the implementation out of line, so that these headers don't get included here? This has a significant impact on clang build times.

(Or possibly this shouldn't be in Basic/TargetInfo at all? I'm not familiar with clang layering, but this sounds more like CodeGen/TargetInfo than Basic/TargetInfo to me.)

https://github.com/llvm/llvm-project/pull/82819


More information about the llvm-commits mailing list