[llvm] [Convergence] Extend cycles to include outside uses of tokens (PR #98006)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 22:20:06 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff c119da23afb42daf588c3e4caf97094689d70688 a454225e8a6e4eb1a2f82138cfb14c53bd65364f -- llvm/include/llvm/Transforms/Scalar/CycleConvergenceExtend.h llvm/lib/Transforms/Scalar/CycleConvergenceExtend.cpp llvm/include/llvm/ADT/GenericCycleImpl.h llvm/include/llvm/ADT/GenericCycleInfo.h llvm/include/llvm/ADT/GenericSSAContext.h llvm/lib/CodeGen/MachineSSAContext.cpp llvm/lib/IR/SSAContext.cpp llvm/lib/Passes/PassBuilder.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Transforms/Scalar/CycleConvergenceExtend.cpp b/llvm/lib/Transforms/Scalar/CycleConvergenceExtend.cpp
index a0546c86a2..48b8520fed 100644
--- a/llvm/lib/Transforms/Scalar/CycleConvergenceExtend.cpp
+++ b/llvm/lib/Transforms/Scalar/CycleConvergenceExtend.cpp
@@ -139,8 +139,7 @@ static bool splitForExtension(CycleInfo &CI, Cycle *DefCycle, BasicBlock *BB,
 
 static void locateExtensions(CycleInfo &CI, Cycle *DefCycle, BasicBlock *BB,
                              TokenDefsMap &TokenDefs,
-                             TokenDefUsesMap &TokenDefUses,
-                             DomTreeUpdater &DTU,
+                             TokenDefUsesMap &TokenDefUses, DomTreeUpdater &DTU,
                              SmallVectorImpl<CallBase *> &ExtPoints) {
   if (auto Iter = TokenDefs.find(BB); Iter != TokenDefs.end()) {
     for (CallBase *Def : Iter->second) {
@@ -172,7 +171,8 @@ static void initialize(ExtensionMap &ExtBorder, TokenDefsMap &TokenDefs,
   for (BasicBlock &BB : F) {
     if (Cycle *DefCycle = CI.getCycle(&BB)) {
       SmallVector<CallBase *> ExtPoints;
-      locateExtensions(CI, DefCycle, &BB, TokenDefs, TokenDefUses, DTU, ExtPoints);
+      locateExtensions(CI, DefCycle, &BB, TokenDefs, TokenDefUses, DTU,
+                       ExtPoints);
       if (!ExtPoints.empty()) {
         auto Success = ExtBorder.try_emplace(DefCycle, std::move(ExtPoints));
         (void)Success;
@@ -222,7 +222,8 @@ PreservedAnalyses CycleConvergenceExtendPass::run(Function &F,
                         << "\n  for token used:  " << *ExtPoint << "\n");
       CI.extendCycle(DefCycle, ExtPoint->getParent(), &TransferredBlocks);
       for (BasicBlock *BB : TransferredBlocks) {
-        locateExtensions(CI, DefCycle, BB, TokenDefs, TokenDefUses, DTU, ExtList);
+        locateExtensions(CI, DefCycle, BB, TokenDefs, TokenDefUses, DTU,
+                         ExtList);
       }
     };
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/98006


More information about the llvm-commits mailing list