[compiler-rt] [compiler-rt][memprof] Do not add libdl to MEMPROF_UNITTEST_LINK_LIBRARIES (PR #98221)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 9 13:57:10 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-pgo
Author: Alexander Shaposhnikov (alexander-shaposhnikov)
<details>
<summary>Changes</summary>
The memprof tests do not actually depend on libdl.
They might have a transitive dependency on libdl through the runtime, but the runtime takes care of itself.
Based on the offline discussions it looks like this piece of code in cmake is a historical artifact.
Test plan: ninja check-all
---
Full diff: https://github.com/llvm/llvm-project/pull/98221.diff
1 Files Affected:
- (modified) compiler-rt/lib/memprof/tests/CMakeLists.txt (-1)
``````````diff
diff --git a/compiler-rt/lib/memprof/tests/CMakeLists.txt b/compiler-rt/lib/memprof/tests/CMakeLists.txt
index 0b5c302a4ce5d..a35f12bc14265 100644
--- a/compiler-rt/lib/memprof/tests/CMakeLists.txt
+++ b/compiler-rt/lib/memprof/tests/CMakeLists.txt
@@ -49,7 +49,6 @@ endif()
set(MEMPROF_UNITTEST_LINK_LIBRARIES
${COMPILER_RT_UNWINDER_LINK_LIBS}
${SANITIZER_TEST_CXX_LIBRARIES})
-append_list_if(COMPILER_RT_HAS_LIBDL -ldl MEMPROF_UNITTEST_LINK_LIBRARIES)
# Adds memprof tests for each architecture.
macro(add_memprof_tests_for_arch arch)
``````````
</details>
https://github.com/llvm/llvm-project/pull/98221
More information about the llvm-commits
mailing list