[llvm] [MC,ELF] Emit warning if a string constant contains newline char. (PR #98060)

Sergei Barannikov via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 06:53:16 PDT 2024


================
@@ -3123,8 +3129,9 @@ bool AsmParser::parseDirectiveAscii(StringRef IDVal, bool ZeroTerminated) {
     // Only support spaces as separators for .ascii directive for now. See the
     // discusssion at https://reviews.llvm.org/D91460 for more details.
     do {
-      if (parseEscapedString(Data))
+      if (parseEscapedString(Data, /* WarnNewline */ true))
----------------
s-barannikov wrote:

The correct style is:
```suggestion
      if (parseEscapedString(Data, /*WarnNewline=*/true))
```

https://github.com/llvm/llvm-project/pull/98060


More information about the llvm-commits mailing list