[llvm] [NVPTX] remove store.params of undef (PR #96940)

Artem Belevich via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 14:44:40 PDT 2024


================
@@ -0,0 +1,93 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
----------------
Artem-B wrote:

Auto-generator is not perfect, but it has two major benefits:
* it's automatic, so the author only need to write the input code, not the checks
* it includes checks for everything, so when something goes wrong I can reason about it without guessing whether the changed output is OK or not, based on hand-written checks that tend to be spotty.

Human-written tests can be good, but usually aren't. The effort of writing a good test falls somewhere between tedious and infeasible. I'll take a good enough automatic test, even if it's overly verbose. It also lowers the review burden as we no longer need to argue about the quality of the checks in the test. Just concentrate on what we're testing and that the generated code is valid.


https://github.com/llvm/llvm-project/pull/96940


More information about the llvm-commits mailing list