[clang] [llvm] [AMDGPU] Report error in clang if wave32 is requested where unsupported (PR #97633)

Shilei Tian via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 14:23:28 PDT 2024


================
@@ -188,8 +188,12 @@ bool AMDGPUTargetInfo::initFeatureMap(
 
   // TODO: Should move this logic into TargetParser
   std::string ErrorMsg;
-  if (!insertWaveSizeFeature(CPU, getTriple(), Features, ErrorMsg)) {
-    Diags.Report(diag::err_invalid_feature_combination) << ErrorMsg;
+  bool IsCombinationError;
+  if (!insertWaveSizeFeature(CPU, getTriple(), Features, ErrorMsg,
----------------
shiltian wrote:

Hmm, okay. Can we make the function return an integer (0 --> no error)? Or better, an enum?

https://github.com/llvm/llvm-project/pull/97633


More information about the llvm-commits mailing list