[llvm] 837dc3b - [TableGen] Use range-based for loops (NFC) (#97678)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 8 13:55:12 PDT 2024
Author: Kazu Hirata
Date: 2024-07-09T05:55:08+09:00
New Revision: 837dc3b179da931e0fd72dbd562c99f649434501
URL: https://github.com/llvm/llvm-project/commit/837dc3b179da931e0fd72dbd562c99f649434501
DIFF: https://github.com/llvm/llvm-project/commit/837dc3b179da931e0fd72dbd562c99f649434501.diff
LOG: [TableGen] Use range-based for loops (NFC) (#97678)
Added:
Modified:
llvm/lib/TableGen/Record.cpp
llvm/lib/TableGen/TGParser.cpp
Removed:
################################################################################
diff --git a/llvm/lib/TableGen/Record.cpp b/llvm/lib/TableGen/Record.cpp
index f9acc68ce5c7f..d5e7af275d792 100644
--- a/llvm/lib/TableGen/Record.cpp
+++ b/llvm/lib/TableGen/Record.cpp
@@ -2283,9 +2283,9 @@ DefInit *VarDefInit::instantiate() {
ArrayRef<Init *> TArgs = Class->getTemplateArgs();
MapResolver R(NewRec);
- for (unsigned I = 0, E = TArgs.size(); I != E; ++I) {
- R.set(TArgs[I], NewRec->getValue(TArgs[I])->getValue());
- NewRec->removeValue(TArgs[I]);
+ for (Init *Arg : TArgs) {
+ R.set(Arg, NewRec->getValue(Arg)->getValue());
+ NewRec->removeValue(Arg);
}
for (auto *Arg : args()) {
diff --git a/llvm/lib/TableGen/TGParser.cpp b/llvm/lib/TableGen/TGParser.cpp
index f899fdb68f758..ce9da960545c2 100644
--- a/llvm/lib/TableGen/TGParser.cpp
+++ b/llvm/lib/TableGen/TGParser.cpp
@@ -4381,8 +4381,7 @@ bool TGParser::CheckTemplateArgValues(
SmallVectorImpl<llvm::ArgumentInit *> &Values, SMLoc Loc, Record *ArgsRec) {
ArrayRef<Init *> TArgs = ArgsRec->getTemplateArgs();
- for (unsigned I = 0, E = Values.size(); I < E; ++I) {
- auto *Value = Values[I];
+ for (llvm::ArgumentInit *&Value : Values) {
Init *ArgName = nullptr;
if (Value->isPositional())
ArgName = TArgs[Value->getIndex()];
@@ -4398,7 +4397,7 @@ bool TGParser::CheckTemplateArgValues(
assert((!isa<TypedInit>(CastValue) ||
cast<TypedInit>(CastValue)->getType()->typeIsA(ArgType)) &&
"result of template arg value cast has wrong type");
- Values[I] = Value->cloneWithValue(CastValue);
+ Value = Value->cloneWithValue(CastValue);
} else {
PrintFatalError(Loc, "Value specified for template argument '" +
Arg->getNameInitAsString() + "' is of type " +
More information about the llvm-commits
mailing list