[llvm] [BOLT][AArch64] Implemented createDummyReturnFunction. (PR #96626)

Paschalis Mpeis via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 09:39:16 PDT 2024


================
@@ -1582,6 +1607,12 @@ class AArch64MCPlusBuilder : public MCPlusBuilder {
     return Instrs;
   }
 
+  InstructionListType createDummyReturnFunction(MCContext *Ctx) const override {
+    InstructionListType Insts(1);
+    createReturn(Insts[0]);
+    return Insts;
----------------
paschalis-mpeis wrote:

Yeap, I also agree and see the pros/cons of both sides.

Just to be clear, your preference is still a base class implementation or making this method pure virtual? (but the rest of the MCBuilder will remain as is).

https://github.com/llvm/llvm-project/pull/96626


More information about the llvm-commits mailing list