[lld] [PAC][lld][AArch64][ELF] Support signed GOT (PR #96169)

Daniil Kovalev via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 09:09:48 PDT 2024


================
@@ -655,6 +655,10 @@ void GotSection::addConstant(const Relocation &r) { relocations.push_back(r); }
 void GotSection::addEntry(const Symbol &sym) {
   assert(sym.auxIdx == symAux.size() - 1);
   symAux.back().gotIdx = numEntries++;
+  if (sym.hasFlag(NEEDS_GOT_AUTH)) {
+    assert(config->emachine == EM_AARCH64);
----------------
kovdan01 wrote:

I probably misunderstood you phrase "and the **above assert** are not useful" - I thought you mean the one I deleted. Thanks for explaining your point, now I get what you meant.

The aarch64-specific useless assert was deleted, see dca427bbf8ab6d53fd01b3d1799d4d723992edd2

https://github.com/llvm/llvm-project/pull/96169


More information about the llvm-commits mailing list