[llvm] [SPIRV] Emitting DebugSource, DebugCompileUnit (PR #97558)

via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 05:57:54 PDT 2024


bwlodarcz wrote:

@VyacheslavLevytskyy @michalpaszkowski Lit test is added.

@VyacheslavLevytskyy A lot of tests inside the [Khronos Translator](https://github.com/KhronosGroup/SPIRV-LLVM-Translator) is using SPT (internal, textual, used only for tests) format and/or are mostly covering [OpenCL.DebugInfo.100](https://registry.khronos.org/SPIR-V/specs/unified1/OpenCL.DebugInfo.100.html#_introduction) standard which we doesn't. Some mixing NonSemantic.DI and OpenCL.DI in the same test file (by separate RUN). Finding which tests are useful for us, translating them, is maybe worth an effort but the risk (of time investment) to reward (finding useful tests) ratio have, in my opinion, question mark when we compare it to just creating new set of tests. In addition to that - especially at the beginning of development there is a lot of cases which aren't covered and with broken tests (inevitable if we port them) - PR's won't be merged - so we would need to disable a lot of them. At some point it's likely that the risk-reward ratio will change. Nevertheless if someone want's to do it, go through them and add to the Backend useful ones - I'm fully supporting it as a optional side quest for everyone who want to participate in DebugInfo development. 


https://github.com/llvm/llvm-project/pull/97558


More information about the llvm-commits mailing list