[llvm] MathExtras: template'ize alignToPowerOf2 (PR #97814)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 8 01:31:47 PDT 2024
================
@@ -488,13 +488,21 @@ constexpr uint64_t alignTo(uint64_t Value, uint64_t Align) {
return CeilDiv * Align;
}
+/// Will overflow only if result is not representable in T.
+template <typename U, typename V, typename T = common_uint<U, V>>
+constexpr T alignToPowerOf2(U Value, V Align) {
+ assert(Align != 0 && (Align & (Align - 1)) == 0 &&
+ "Align must be a power of 2");
+ T CeilDiv = divideCeil(Value, Align);
+ return CeilDiv * Align;
+}
+
+/// Fallback when arguments aren't integral.
constexpr uint64_t alignToPowerOf2(uint64_t Value, uint64_t Align) {
assert(Align != 0 && (Align & (Align - 1)) == 0 &&
"Align must be a power of 2");
- // Replace unary minus to avoid compilation error on Windows:
- // "unary minus operator applied to unsigned type, result still unsigned"
- uint64_t NegAlign = (~Align) + 1;
- return (Value + Align - 1) & NegAlign;
----------------
jayfoad wrote:
I think: `Align - 1` cannot overflow and `Value + (Align - 1)` can only overflow if the result is going to overflow to 0 anyway. Unless you have a counterexample?
https://github.com/llvm/llvm-project/pull/97814
More information about the llvm-commits
mailing list