[llvm] [AMDGPU][MC] Allow UC_VERSION_* constant reuse (PR #96461)

Sun Jul 7 03:17:01 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-armv7-2stage` running on `linaro-clang-armv7-2stage` while building `llvm` at step 10 "ninja check 2".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/79/builds/312

Here is the relevant piece of the build log for the reference:
```
Step 10 (ninja check 2) failure: stage 2 checked (failure)
...
[848/1154] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/VectorBuilderTest.cpp.o
[849/1154] Building CXX object unittests/MC/CMakeFiles/MCTests.dir/MCDisassemblerTest.cpp.o
[850/1154] Linking CXX executable unittests/Linker/LinkerTests
[851/1154] Building CXX object unittests/MC/CMakeFiles/MCTests.dir/MCInstPrinter.cpp.o
[852/1154] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/ValueMapTest.cpp.o
[853/1154] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/VFABIDemanglerTest.cpp.o
[854/1154] Building CXX object unittests/MC/AMDGPU/CMakeFiles/AMDGPUMCTests.dir/DwarfRegMappings.cpp.o
[855/1154] Building CXX object unittests/MC/CMakeFiles/MCTests.dir/DwarfLineTableHeaders.cpp.o
[856/1154] Building CXX object unittests/Object/CMakeFiles/ObjectTests.dir/COFFObjectFileTest.cpp.o
[857/1154] Building CXX object unittests/MC/AMDGPU/CMakeFiles/AMDGPUMCTests.dir/Disassembler.cpp.o
FAILED: unittests/MC/AMDGPU/CMakeFiles/AMDGPUMCTests.dir/Disassembler.cpp.o 
/home/tcwg-buildbot/worker/clang-armv7-2stage/stage1.install/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/clang-armv7-2stage/stage2/unittests/MC/AMDGPU -I/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/unittests/MC/AMDGPU -I/home/tcwg-buildbot/worker/clang-armv7-2stage/stage2/include -I/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/include -I/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/lib/Target/AMDGPU -I/home/tcwg-buildbot/worker/clang-armv7-2stage/stage2/lib/Target/AMDGPU -I/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/third-party/unittest/googletest/include -I/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/third-party/unittest/googlemock/include -mcpu=cortex-a15 -marm -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/MC/AMDGPU/CMakeFiles/AMDGPUMCTests.dir/Disassembler.cpp.o -MF unittests/MC/AMDGPU/CMakeFiles/AMDGPUMCTests.dir/Disassembler.cpp.o.d -o unittests/MC/AMDGPU/CMakeFiles/AMDGPUMCTests.dir/Disassembler.cpp.o -c /home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/unittests/MC/AMDGPU/Disassembler.cpp
/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/unittests/MC/AMDGPU/Disassembler.cpp:110:43: error: non-const lvalue reference to type 'uint64_t' (aka 'unsigned long long') cannot bind to a value of unrelated type 'size_t' (aka 'unsigned int')
  110 |   Status = DisAsm1->getInstruction(Inst1, InstSize, Bytes, 0, Annotations);
      |                                           ^~~~~~~~
/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h:134:64: note: passing argument to parameter 'Size' here
  134 |   virtual DecodeStatus getInstruction(MCInst &Instr, uint64_t &Size,
      |                                                                ^
/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/unittests/MC/AMDGPU/Disassembler.cpp:125:43: error: non-const lvalue reference to type 'uint64_t' (aka 'unsigned long long') cannot bind to a value of unrelated type 'size_t' (aka 'unsigned int')
  125 |   Status = DisAsm2->getInstruction(Inst2, InstSize, Bytes, 0, Annotations);
      |                                           ^~~~~~~~
/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h:134:64: note: passing argument to parameter 'Size' here
  134 |   virtual DecodeStatus getInstruction(MCInst &Instr, uint64_t &Size,
      |                                                                ^
/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/unittests/MC/AMDGPU/Disassembler.cpp:193:38: error: non-const lvalue reference to type 'uint64_t' (aka 'unsigned long long') cannot bind to a value of unrelated type 'size_t' (aka 'unsigned int')
  193 |         DisAsm->getInstruction(Inst, InstSize, Bytes, 0, Annotations);
      |                                      ^~~~~~~~
/home/tcwg-buildbot/worker/clang-armv7-2stage/llvm/llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h:134:64: note: passing argument to parameter 'Size' here
  134 |   virtual DecodeStatus getInstruction(MCInst &Instr, uint64_t &Size,
      |                                                                ^
3 errors generated.
[858/1154] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/VPIntrinsicTest.cpp.o
[859/1154] Building CXX object unittests/MC/SystemZ/CMakeFiles/SystemZAsmLexerTests.dir/SystemZAsmLexerTest.cpp.o
[860/1154] Building CXX object unittests/Object/CMakeFiles/ObjectTests.dir/ArchiveTest.cpp.o
[861/1154] Linking CXX executable unittests/MC/MCTests
[862/1154] Building CXX object unittests/Object/CMakeFiles/ObjectTests.dir/ObjectFileTest.cpp.o
[863/1154] Building CXX object unittests/Object/CMakeFiles/ObjectTests.dir/OffloadingTest.cpp.o
[864/1154] Building CXX object unittests/ObjCopy/CMakeFiles/ObjCopyTests.dir/ObjCopyTest.cpp.o
[865/1154] Building CXX object unittests/Object/CMakeFiles/ObjectTests.dir/MinidumpTest.cpp.o
[866/1154] Building CXX object unittests/ObjectYAML/CMakeFiles/ObjectYAMLTests.dir/DWARFYAMLTest.cpp.o
[867/1154] Building CXX object unittests/ObjectYAML/CMakeFiles/ObjectYAMLTests.dir/MinidumpYAMLTest.cpp.o
[868/1154] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/PassBuilderCallbacksTest.cpp.o
[869/1154] Building CXX object unittests/ObjectYAML/CMakeFiles/ObjectYAMLTests.dir/DXContainerYAMLTest.cpp.o
[870/1154] Building CXX object unittests/MI/CMakeFiles/MITests.dir/LiveIntervalTest.cpp.o
[871/1154] Building CXX object unittests/MIR/CMakeFiles/MIRTests.dir/MachineMetadata.cpp.o
[872/1154] Building CXX object unittests/Frontend/CMakeFiles/LLVMFrontendTests.dir/OpenMPDecompositionTest.cpp.o
[873/1154] Building CXX object unittests/ObjectYAML/CMakeFiles/ObjectYAMLTests.dir/ELFYAMLTest.cpp.o
ninja: build stopped: subcommand failed.

```

https://github.com/llvm/llvm-project/pull/96461