[llvm] Make the logic for checking scatter vectorized nodes of GEP clearer (PR #97826)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 5 18:10:11 PDT 2024
https://github.com/tcwzxx updated https://github.com/llvm/llvm-project/pull/97826
>From 4963f6ce3596b76efda3ceb73afedf9639c8b029 Mon Sep 17 00:00:00 2001
From: zhizhixu <zhizhixu at tencent.com>
Date: Fri, 5 Jul 2024 21:17:17 +0800
Subject: [PATCH] Make the logic for checking scatter vectorized nodes of GEP
clearer
---
llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 64c5fb49ec85c..64d4fd2f71281 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -6725,9 +6725,9 @@ void BoUpSLP::buildTree_rec(ArrayRef<Value *> VL, unsigned Depth,
bool IsScatterVectorizeUserTE =
UserTreeIdx.UserTE &&
UserTreeIdx.UserTE->State == TreeEntry::ScatterVectorize;
- bool AreAllSameInsts =
- (S.getOpcode() && allSameBlock(VL)) ||
- (S.OpValue->getType()->isPointerTy() && IsScatterVectorizeUserTE &&
+ bool AreAllSameBlock = (S.getOpcode() && allSameBlock(VL));
+ bool AreScatterAllGEPSameBlock =
+ (IsScatterVectorizeUserTE && S.OpValue->getType()->isPointerTy() &&
VL.size() > 2 &&
all_of(VL,
[&BB](Value *V) {
@@ -6741,6 +6741,7 @@ void BoUpSLP::buildTree_rec(ArrayRef<Value *> VL, unsigned Depth,
BB &&
sortPtrAccesses(VL, UserTreeIdx.UserTE->getMainOp()->getType(), *DL, *SE,
SortedIndices));
+ bool AreAllSameInsts = AreAllSameBlock || AreScatterAllGEPSameBlock;
if (!AreAllSameInsts || allConstant(VL) || isSplat(VL) ||
(isa<InsertElementInst, ExtractValueInst, ExtractElementInst>(
S.OpValue) &&
@@ -6820,9 +6821,7 @@ void BoUpSLP::buildTree_rec(ArrayRef<Value *> VL, unsigned Depth,
// Special processing for sorted pointers for ScatterVectorize node with
// constant indeces only.
- if (AreAllSameInsts && UserTreeIdx.UserTE &&
- UserTreeIdx.UserTE->State == TreeEntry::ScatterVectorize &&
- !(S.getOpcode() && allSameBlock(VL))) {
+ if (!AreAllSameBlock && AreScatterAllGEPSameBlock) {
assert(S.OpValue->getType()->isPointerTy() &&
count_if(VL, IsaPred<GetElementPtrInst>) >= 2 &&
"Expected pointers only.");
More information about the llvm-commits
mailing list