[compiler-rt] 44248d2 - [PGO][compiler-rt] Add a test to ensure include files do not diverge (#97775)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 10:56:36 PDT 2024


Author: Aiden Grossman
Date: 2024-07-05T10:56:33-07:00
New Revision: 44248d2d248be43c3e55d1ab6808342f63e0c70c

URL: https://github.com/llvm/llvm-project/commit/44248d2d248be43c3e55d1ab6808342f63e0c70c
DIFF: https://github.com/llvm/llvm-project/commit/44248d2d248be43c3e55d1ab6808342f63e0c70c.diff

LOG: [PGO][compiler-rt] Add a test to ensure include files do not diverge (#97775)

Memprof has two include files that are duplicated between LLVM and
compiler-rt. They need to stay in sync to ensure correct functionality,
but the comments can be somewhat easy to miss, which causes fixups like
839ed1ba553346b0c225e9b839cf3cb716dc7412 to be needed. This patch adds a
test to ensure that the files are the same between LLVM and compiler-rt
to catch this ideally before commit, but if not, soon afterwards.

There is additionally `InstrProfData.inc` for some PGO variants that is
added to the same test here as well.

Added: 
    compiler-rt/test/profile/check-same-common-code.test

Modified: 
    

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/profile/check-same-common-code.test b/compiler-rt/test/profile/check-same-common-code.test
new file mode 100644
index 00000000000000..81b9836760dd66
--- /dev/null
+++ b/compiler-rt/test/profile/check-same-common-code.test
@@ -0,0 +1,7 @@
+;
+; NOTE: if this test fails, please make sure the files are identical
+; copies of each other.
+;
+; RUN: 
diff  %crt_src/include/profile/MIBEntryDef.inc %llvm_src/include/llvm/ProfileData/MIBEntryDef.inc
+; RUN: 
diff  %crt_src/include/profile/MemProfData.inc %llvm_src/include/llvm/ProfileData/MemProfData.inc
+; RUN: 
diff  %crt_src/include/profile/InstrProfData.inc %llvm_src/include/llvm/ProfileData/InstrProfData.inc


        


More information about the llvm-commits mailing list