[llvm] [BOLT][DWARF][NFC] Cleanup version check (PR #97839)

Sayhaan Siddiqui via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 10:47:15 PDT 2024


https://github.com/sayhaan created https://github.com/llvm/llvm-project/pull/97839

Cleans up version check to remove redundant else branch

>From 31434548752570fb5c41f1fb0dec70105ab9d28f Mon Sep 17 00:00:00 2001
From: Sayhaan Siddiqui <sayhaan at meta.com>
Date: Fri, 28 Jun 2024 11:14:51 -0700
Subject: [PATCH] Cleanup version check

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: https://phabricator.intern.facebook.com/D59175264
---
 bolt/lib/Rewrite/DWARFRewriter.cpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp
index 1f426d0adfc61..bf27c64d14315 100644
--- a/bolt/lib/Rewrite/DWARFRewriter.cpp
+++ b/bolt/lib/Rewrite/DWARFRewriter.cpp
@@ -1342,10 +1342,7 @@ void DWARFRewriter::updateDWARFObjectAddressRanges(
       assert(RangesWriterIterator != LegacyRangesWritersByCU.end() &&
              "RangesWriter does not exist for DWOId");
       RangesWriterIterator->second->setDie(&Die);
-    } else if (Unit.getVersion() == 5) {
-      DIEBldr.addValue(&Die, dwarf::DW_AT_rnglists_base,
-                       dwarf::DW_FORM_sec_offset, DIEInteger(*RangesBase));
-    } else {
+    } else if (Unit.getVersion() >= 5) {
       DIEBldr.addValue(&Die, dwarf::DW_AT_rnglists_base,
                        dwarf::DW_FORM_sec_offset, DIEInteger(*RangesBase));
     }



More information about the llvm-commits mailing list