[compiler-rt] [llvm] [LLVM][compiler-rt][AArch64] Refactor AArch64 CPU features (PR #97777)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 09:28:57 PDT 2024


boomanaiden154 wrote:

> This looks like an improvement, but I'm still not sure why we couldn't just include the same .inc file from two different places.

I don't believe the out-of-tree builds matter anymore with a refactoring of the runtimes build a while back (but I could be wrong). @MaskRay would probably have better context on any technical reasons why. The licensing constraints also might not want to be something we want to touch, although I would think copying and pasting selected `.inc` files would incur the same restraints as just copying it over at build time.

Anyways, I definitely think this is an improvement. Even if unifying the `.inc` files is actually viable, it's another trivial patch after this one (delete the test and one of the `.inc` files), made slightly easier by the refactoring in this patch.

https://github.com/llvm/llvm-project/pull/97777


More information about the llvm-commits mailing list