[compiler-rt] [MemProf][compiler-rt] Add a test to ensure include files do not diverge (PR #97775)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 4 16:49:52 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-pgo
Author: Aiden Grossman (boomanaiden154)
<details>
<summary>Changes</summary>
Memprof has two include files that are duplicated between LLVM and compiler-rt. They need to stay in sync to ensure correct functionality, but the comments can be somewhat easy to miss, which causes fixups like 839ed1ba553346b0c225e9b839cf3cb716dc7412 to be needed. This patch adds a test to ensure that the files are the same between LLVM and compiler-rt to catch this ideally before commit, but if not, soon afterwards.
---
Full diff: https://github.com/llvm/llvm-project/pull/97775.diff
1 Files Affected:
- (added) compiler-rt/test/profile/check-same-common-code.test (+6)
``````````diff
diff --git a/compiler-rt/test/profile/check-same-common-code.test b/compiler-rt/test/profile/check-same-common-code.test
new file mode 100644
index 0000000000000..5cede37fe06c2
--- /dev/null
+++ b/compiler-rt/test/profile/check-same-common-code.test
@@ -0,0 +1,6 @@
+;
+; NOTE: if this test fails, please make sure the relevant copies are identical
+; copies of each other.
+;
+; RUN: diff %crt_src/include/profile/MIBEntryDef.inc %llvm_src/include/llvm/ProfileData/MIBEntryDef.inc
+; RUN: diff %crt_src/include/profile/MemProfData.inc %llvm_src/include/llvm/ProfileData/MemProfData.inc
``````````
</details>
https://github.com/llvm/llvm-project/pull/97775
More information about the llvm-commits
mailing list