[llvm] [llvm] Fix the MCSubtargetInfo used for module-level assembly. (PR #97685)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 4 00:22:57 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-binary-utilities

Author: Chris Copeland (chrisnc)

<details>
<summary>Changes</summary>

Provide both the default target CPU and default target features from the
module's context, rather than empty strings.

Fixes #<!-- -->61991.


---
Full diff: https://github.com/llvm/llvm-project/pull/97685.diff


1 Files Affected:

- (modified) llvm/lib/Object/ModuleSymbolTable.cpp (+5-1) 


``````````diff
diff --git a/llvm/lib/Object/ModuleSymbolTable.cpp b/llvm/lib/Object/ModuleSymbolTable.cpp
index d8f520ad02c2f..079c33c801f6e 100644
--- a/llvm/lib/Object/ModuleSymbolTable.cpp
+++ b/llvm/lib/Object/ModuleSymbolTable.cpp
@@ -22,6 +22,7 @@
 #include "llvm/IR/GlobalValue.h"
 #include "llvm/IR/GlobalVariable.h"
 #include "llvm/IR/InlineAsm.h"
+#include "llvm/IR/LLVMContext.h"
 #include "llvm/IR/Module.h"
 #include "llvm/MC/MCAsmInfo.h"
 #include "llvm/MC/MCContext.h"
@@ -92,8 +93,11 @@ initializeRecordStreamer(const Module &M,
   if (!MAI)
     return;
 
+  LLVMContext &Context = M.getContext();
+
   std::unique_ptr<MCSubtargetInfo> STI(
-      T->createMCSubtargetInfo(TT.str(), "", ""));
+      T->createMCSubtargetInfo(TT.str(), Context.getDefaultTargetCPU(),
+                               Context.getDefaultTargetFeatures()));
   if (!STI)
     return;
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/97685


More information about the llvm-commits mailing list