[llvm] [Support] Use range-based for loops (NFC) (PR #97657)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 3 16:52:26 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-support
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/97657.diff
1 Files Affected:
- (modified) llvm/lib/Support/CommandLine.cpp (+10-12)
``````````diff
diff --git a/llvm/lib/Support/CommandLine.cpp b/llvm/lib/Support/CommandLine.cpp
index 6dc0c86cea894..ecc487a17ccca 100644
--- a/llvm/lib/Support/CommandLine.cpp
+++ b/llvm/lib/Support/CommandLine.cpp
@@ -1733,9 +1733,9 @@ bool CommandLineParser::ParseCommandLineOptions(int argc,
} else if (!ConsumeAfterOpt) {
// Positional args have already been handled if ConsumeAfter is specified.
unsigned ValNo = 0, NumVals = static_cast<unsigned>(PositionalVals.size());
- for (size_t i = 0, e = PositionalOpts.size(); i != e; ++i) {
- if (RequiresValue(PositionalOpts[i])) {
- ProvidePositionalOption(PositionalOpts[i], PositionalVals[ValNo].first,
+ for (Option *Opt : PositionalOpts) {
+ if (RequiresValue(Opt)) {
+ ProvidePositionalOption(Opt, PositionalVals[ValNo].first,
PositionalVals[ValNo].second);
ValNo++;
--NumPositionalRequired; // We fulfilled our duty...
@@ -1745,16 +1745,15 @@ bool CommandLineParser::ParseCommandLineOptions(int argc,
// do not give it values that others need. 'Done' controls whether the
// option even _WANTS_ any more.
//
- bool Done = PositionalOpts[i]->getNumOccurrencesFlag() == cl::Required;
+ bool Done = Opt->getNumOccurrencesFlag() == cl::Required;
while (NumVals - ValNo > NumPositionalRequired && !Done) {
- switch (PositionalOpts[i]->getNumOccurrencesFlag()) {
+ switch (Opt->getNumOccurrencesFlag()) {
case cl::Optional:
Done = true; // Optional arguments want _at most_ one value
[[fallthrough]];
case cl::ZeroOrMore: // Zero or more will take all they can get...
case cl::OneOrMore: // One or more will take all they can get...
- ProvidePositionalOption(PositionalOpts[i],
- PositionalVals[ValNo].first,
+ ProvidePositionalOption(Opt, PositionalVals[ValNo].first,
PositionalVals[ValNo].second);
ValNo++;
break;
@@ -1767,11 +1766,10 @@ bool CommandLineParser::ParseCommandLineOptions(int argc,
} else {
assert(ConsumeAfterOpt && NumPositionalRequired <= PositionalVals.size());
unsigned ValNo = 0;
- for (size_t J = 0, E = PositionalOpts.size(); J != E; ++J)
- if (RequiresValue(PositionalOpts[J])) {
- ErrorParsing |= ProvidePositionalOption(PositionalOpts[J],
- PositionalVals[ValNo].first,
- PositionalVals[ValNo].second);
+ for (Option *Opt : PositionalOpts)
+ if (RequiresValue(Opt)) {
+ ErrorParsing |= ProvidePositionalOption(
+ Opt, PositionalVals[ValNo].first, PositionalVals[ValNo].second);
ValNo++;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/97657
More information about the llvm-commits
mailing list