[llvm] [CodeGen] Refactor and document ThunkInserter (PR #97468)

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 05:44:05 PDT 2024


================
@@ -183,15 +183,13 @@ static const struct ThunkNameAndReg {
 namespace {
 struct SLSBLRThunkInserter : ThunkInserter<SLSBLRThunkInserter> {
   const char *getThunkPrefix() { return SLSBLRNamePrefix; }
-  bool mayUseThunk(const MachineFunction &MF, bool InsertedThunks) {
-    if (InsertedThunks)
-      return false;
+  bool mayUseThunk(const MachineFunction &MF) {
+    // FIXME: ComdatThunks is only accumulated until the first thunk is created.
----------------
kbeyls wrote:

I don't fully understand this FIXME very well. Could you explain this in a bit more detail?


https://github.com/llvm/llvm-project/pull/97468


More information about the llvm-commits mailing list