[lld] [llvm] [llvm-readobj][ELF] Alter JSON/LLVM output on note sections to allow for multiple notes per section in JSON (PR #96813)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 00:12:56 PDT 2024


jh7370 wrote:

> > Thanks for the update. LGTM but give @jh7370 a chance.
> 
> Will do.

Taking a look now.

> > The example below `But is now:` in the description should be adjusted now that `ListScope L(W, "NoteSections");` is used.
> 
> Yeah I am planning on cleaning up the commit message before merging

Just to be abundantly clear, the only thing you need to "clean up" for the final merged-in commit to have the right commit message is the description of the PR: LLVM's GitHub uses the "Use PR description by default when squashing and merging".

https://github.com/llvm/llvm-project/pull/96813


More information about the llvm-commits mailing list