[llvm] [ThinLTO] Use a set rather than a map to track exported ValueInfos. (PR #97360)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 22:55:50 PDT 2024


================
@@ -1154,29 +1147,25 @@ void llvm::ComputeCrossModuleImport(
   for (auto &ModuleImports : ImportLists) {
     auto ModName = ModuleImports.first;
     auto &Exports = ExportLists[ModName];
-    unsigned DefinedGVS = 0, DefinedFS = 0;
-    unsigned NumGVS =
-        numGlobalVarSummaries(Index, Exports, DefinedGVS, DefinedFS);
+    unsigned DefinedFS = 0;
+    unsigned NumGVS = numGlobalVarSummaries(Index, Exports, DefinedFS);
     LLVM_DEBUG(dbgs() << "* Module " << ModName << " exports " << DefinedFS
                       << " function as definitions, "
                       << Exports.size() - NumGVS - DefinedFS
----------------
teresajohnson wrote:

I think this will result in 0, since I believe NumGVS + DefinedFS should be the same as Exports.size() (see my comment above).

https://github.com/llvm/llvm-project/pull/97360


More information about the llvm-commits mailing list