[llvm] [RISCV] Add a check in lowerSELECT after foldBinOpIntoSelectIfProfitable (PR #97391)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 14:37:44 PDT 2024


topperc wrote:

> > The title and the description don't say what the extra check is.
> 
> The description says what the check is.

It could be a little better in my opinion. The first sentence says that `foldBinOpIntoSelectIfProfitable` returned a constant node. The second sentence says a new check is added. Reading the two sentences together, you might think that the new check is that the node isn't a constant. But that's not exactly what the new check is.

https://github.com/llvm/llvm-project/pull/97391


More information about the llvm-commits mailing list