[compiler-rt] [llvm] [ORC][Runtime] Add `dlupdate` for MachO (PR #97441)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 2 10:04:19 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 26814bbd4f65934d4e231ce407ec1b62c9d81df7 3d16e5c04c559d456dd70e13c4ab736c85d1e574 -- compiler-rt/lib/orc/dlfcn_wrapper.cpp compiler-rt/lib/orc/macho_platform.cpp compiler-rt/lib/orc/macho_platform.h llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h llvm/lib/ExecutionEngine/Orc/LLJIT.cpp llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/compiler-rt/lib/orc/macho_platform.cpp b/compiler-rt/lib/orc/macho_platform.cpp
index 353e2fa8ae..f229e15585 100644
--- a/compiler-rt/lib/orc/macho_platform.cpp
+++ b/compiler-rt/lib/orc/macho_platform.cpp
@@ -380,9 +380,10 @@ private:
Expected<void *> dlupdateImpl(void *DSOHandle, int Mode);
Error dlupdateFull(std::unique_lock<std::mutex> &JDStatesLock,
- JITDylibState &JDS);
+ JITDylibState &JDS);
Error dlupdateInitialize(std::unique_lock<std::mutex> &JDStatesLock,
- JITDylibState &JDS, MachOJITDylibDepInfoMap &DepInfo);
+ JITDylibState &JDS,
+ MachOJITDylibDepInfoMap &DepInfo);
Error dlcloseImpl(void *DSOHandle);
Error dlcloseDeinitialize(std::unique_lock<std::mutex> &JDStatesLock,
@@ -1259,7 +1260,7 @@ Error MachOPlatformRuntimeState::dlopenInitialize(
}
Expected<void *> MachOPlatformRuntimeState::dlupdateImpl(void *DSOHandle,
- int Mode) {
+ int Mode) {
std::unique_lock<std::mutex> Lock(JDStatesMutex);
// Try to find JITDylib state by DSOHandle.
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h b/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h
index b42f13bf3f..2660b9f74f 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h
@@ -13,6 +13,7 @@
#ifndef LLVM_EXECUTIONENGINE_ORC_LLJIT_H
#define LLVM_EXECUTIONENGINE_ORC_LLJIT_H
+#include "llvm/ADT/SmallSet.h"
#include "llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h"
#include "llvm/ExecutionEngine/Orc/CompileUtils.h"
#include "llvm/ExecutionEngine/Orc/ExecutionUtils.h"
@@ -22,7 +23,6 @@
#include "llvm/ExecutionEngine/Orc/ThreadSafeModule.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/ThreadPool.h"
-#include "llvm/ADT/SmallSet.h"
#include <variant>
namespace llvm {
diff --git a/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp b/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp
index 3743658823..75c8d0dd74 100644
--- a/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/LLJIT.cpp
@@ -622,8 +622,8 @@ Error ORCPlatformSupport::initialize(orc::JITDylib &JD) {
InitializedDylib.insert(&JD);
}
- if (auto WrapperAddr = ES.lookup(
- MainSearchOrder, J.mangleAndIntern(WrapperToCall))) {
+ if (auto WrapperAddr =
+ ES.lookup(MainSearchOrder, J.mangleAndIntern(WrapperToCall))) {
if (dlupdate)
return ES.callSPSWrapper<SPSDLUpdateSig>(WrapperAddr->getAddress(),
DSOHandles[&JD], DSOHandles[&JD],
``````````
</details>
https://github.com/llvm/llvm-project/pull/97441
More information about the llvm-commits
mailing list