[llvm] [RISCV] Add a check in lowerSELECT after foldBinOpIntoSelectIfProfitable (PR #97391)
Mikhail Gudim via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 2 07:53:29 PDT 2024
================
@@ -7664,7 +7664,10 @@ SDValue RISCVTargetLowering::lowerSELECT(SDValue Op, SelectionDAG &DAG) const {
if (SDValue NewSel = foldBinOpIntoSelectIfProfitable(*Op->use_begin(),
DAG, Subtarget)) {
DAG.ReplaceAllUsesWith(BinOp, &NewSel);
- return lowerSELECT(NewSel, DAG);
+ if (NewSel.getOpcode() == ISD::SELECT)
+ return lowerSELECT(NewSel, DAG);
+ else
+ return NewSel;
----------------
mgudim wrote:
I think using ternary operator is preferred in LLVM
https://github.com/llvm/llvm-project/pull/97391
More information about the llvm-commits
mailing list