koachan wrote: > Unit test looks good to me as well. I would prefer squashing the two additional commits into the original commits though since the test belongs to the change. Yep, it'll be squashed automatically during the merge :) https://github.com/llvm/llvm-project/pull/96583