[llvm] [NFC][AlwaysInliner] Reduce AlwaysInliner memory consumption. (PR #96958)

Arthur Eubanks via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 1 14:06:42 PDT 2024


================
@@ -37,86 +37,74 @@ bool AlwaysInlineImpl(
     function_ref<BlockFrequencyInfo &(Function &)> GetBFI) {
   SmallSetVector<CallBase *, 16> Calls;
   bool Changed = false;
-  SmallVector<Function *, 16> InlinedFunctions;
-  for (Function &F : M) {
-    // When callee coroutine function is inlined into caller coroutine function
-    // before coro-split pass,
-    // coro-early pass can not handle this quiet well.
-    // So we won't inline the coroutine function if it have not been unsplited
+  SmallVector<Function *, 16> InlinedComdatFunctions;
+
+  for (Function &F : make_early_inc_range(M)) {
----------------
aeubanks wrote:

I think it's not immediately obvious since the deletion happens further down so I'd write a comment, but won't object if you omit the comment

https://github.com/llvm/llvm-project/pull/96958


More information about the llvm-commits mailing list