[compiler-rt] [compiler-rt][test]Use c-style headers in instrprof-vtable-value-prof.cpp (PR #97245)

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 30 21:33:46 PDT 2024


petrhosek wrote:

Those other tests are C sources though, this one is a C++. There are other tests in compiler-rt that use the C++ headers, for example https://github.com/llvm/llvm-project/blob/9b9405621bcc55b74d2177c960c21f62cc95e6fd/compiler-rt/test/tsan/custom_mutex4.cpp.

It looks that builder doesn't run any of those other tests, but if it did, those would likely fail as well for the same reason. Those headers should be provided by the C++ standard library; it looks like the C++ standard library on that builder is eithre missing or misconfigured. I don't think it's reasonable to avoid C++ headers in compiler-rt tests just because a single builder is broken, we instead should reach out to the maintainer of that builder and ask them to fix their C++ standard library.

https://github.com/llvm/llvm-project/pull/97245


More information about the llvm-commits mailing list